Avoid re-parsing global images that failed decoding (issue 18042, PR 17428 follow-up) #18047
Conversation
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/680322ba53bd9ff/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/b3d520195b38933/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/680322ba53bd9ff/output.txt Total script time: 27.47 mins
Image differences available at: http://54.241.84.105:8877/680322ba53bd9ff/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/b3d520195b38933/output.txt Total script time: 42.82 mins
Image differences available at: http://54.193.163.58:8877/b3d520195b38933/reftest-analyzer.html#web=eq.log |
|
I tested the changes in this PR with the pdf files I was having problems with. |
Snuffleupagus
requested review from
calixteman
and removed request for
calixteman
…17428 follow-up) For images that failed to decode once we want to avoid a pointless round-trip to the main-thread, which could otherwise happen for globally cached images.
Snuffleupagus
force-pushed
the
issue-18042
branch
from
6f821db
to
c5f9243
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/728546f044e3c2b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/728546f044e3c2b/output.txt Total script time: 1.16 mins Published |
For images that failed to decode once we want to avoid a pointless round-trip to the main-thread, which could otherwise happen for globally cached images.
Please note: Submitted as a "draft", since I'm not keen on making these changes without test-coverage.Given the lack of a real-world PDF document, since none was provided, I've tried to manually create a broken one. However, I obviously cannot tell if it properly covers the original issue.