Allow null additionally to any format #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @maxwrlr, this seems very good. Could you additionally just update the README file in your MR please? |
|
I adjusted the README. I hope what I wrote makes sense. |
|
@maxwrlr thanks for the addition of the doc. It's good now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello convicts,
the current options do not allow null additionally to any format.
To get it working it was always necessary to create a new format around any existing format just to alloww null. What a mess!
This pull request tries to introduce the
nullableoption, which, if truthy, makes convict accept a configured null property before a dedicated format checking function would be called.This change doesn't affect existing behaviour.
This could also be seen as a fix for #292 .