Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace packaging.LegacyVersion use with mozilla_version #635

Closed
whimboo opened this issue Jan 17, 2023 · 1 comment
Closed

Replace packaging.LegacyVersion use with mozilla_version #635

whimboo opened this issue Jan 17, 2023 · 1 comment
Milestone
1.28.0

Comments

@whimboo
Copy link
Contributor

whimboo commented Jan 17, 2023

The LegacyVersion class has been removed from the packaging package. We could switch to Version but then several failures exist when we are trying to compare versions with suffixes. We should find an alternative or have it implemented ourselves.
@whimboo whimboo added this to the 1.28.0 milestone Jan 17, 2023
This was referenced Jan 17, 2023
Merged
Closed
jfx2006 added a commit to jfx2006/mozdownload that referenced this issue Feb 28, 2023
@jfx2006
Use mozilla-version for version sorting instead of packaging.LegacyVe…
b928767 
…rsion. Fixes mozilla#635

As packaging.LegacyVersion is gone, and packaging.Version produces
too many errors, use the various version classes from mozilla_version.gecko
when looking for the latest version of a supported application.
@jfx2006 jfx2006 mentioned this issue Feb 28, 2023
Merged
@whimboo whimboo changed the title Find alternative for packaging.LegacyVersion Replace packaging.LegacyVersion use with mozilla_version Apr 17, 2023
@whimboo
Copy link
Contributor Author

whimboo commented Apr 17, 2023

The solution we ended up with is by using the mozilla-version package.

@whimboo whimboo closed this as completed Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.28.0
Development

No branches or pull requests
1 participant
@whimboo