Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should stop using Protocol as our main styling library #682

Open
Iinh opened this issue Jun 17, 2021 · 1 comment
Open

We should stop using Protocol as our main styling library #682

Iinh opened this issue Jun 17, 2021 · 1 comment

Comments

@Iinh
Copy link
Contributor

Iinh commented Jun 17, 2021

See @wlach's comments:

I'm concerned about the interaction of protocol and this site -- based on the error output I'm seeing (e.g. complaints about unused css selectors) it looks like it's importing a very large chunk of protocol for each svelte component. I'm beginning to think we should probably stop using protocol as a library-- while the idea of sharing styles across Mozilla properties is appealing, it's proving difficult to adapt the assets (which were created to serve the needs of a completely different site-building technology) to the needs of our particular application and I would expect ongoing issues from continuing to attempt to do this.

I'd probably vote to keep using scss, the protocol tokens and whatever styles make sense to copy from the library but yeah, removing our explicit dependency on the package makes sense to me.
@Iinh Iinh self-assigned this Jun 17, 2021
wlach added a commit that referenced this issue Nov 26, 2021
@wlach
Protocol/SCSS refactoring
4a9e9b6 
* Move away from making scss the default, instead specify it manually
  ("defaults" are now discouraged: sveltejs/svelte-preprocess#362)
* Import only the parts of protocol we actually need for each component,
  this speeds up the build by a fair chunk (50.25 -> 18.85 seconds on
  my MacBook) and helps pave the way to #682.
@wlach wlach mentioned this issue Nov 26, 2021
Merged
wlach added a commit that referenced this issue Nov 29, 2021
@wlach
Protocol/SCSS refactoring
dfd08e7 
* Move away from making scss the default, instead specify it manually
  ("defaults" are now discouraged: sveltejs/svelte-preprocess#362)
* Import only the parts of protocol we actually need for each component,
  this speeds up the build by a fair chunk (50.25 -> 18.85 seconds on
  my MacBook) and helps pave the way to #682.
wlach added a commit that referenced this issue Nov 29, 2021
@wlach
Protocol/SCSS refactoring (#973)
af70a27 
* Move away from making scss the default, instead specify it manually
  ("defaults" are now discouraged: sveltejs/svelte-preprocess#362)
* Import only the parts of protocol we actually need for each component,
  this speeds up the build by a fair chunk (50.25 -> 18.85 seconds on
  my MacBook) and helps pave the way to #682.
@Iinh Iinh removed their assignment Jul 13, 2022
@Iinh Iinh mentioned this issue May 22, 2023
Merged
@Dexterp37
Copy link
Contributor

@Iinh does this still apply? Looks like we can now only get what we're interested in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dexterp37 @Iinh