Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding metric name to page title #2124

Open
brizental opened this issue Feb 9, 2024 · 3 comments
Open

Consider adding metric name to page title #2124

brizental opened this issue Feb 9, 2024 · 3 comments

Comments

@brizental
Copy link
Contributor

It just looks weird when you put a glean dicitonary link in Slack or Jira because they sub it for the page title and the page title is always Glean Dictionary. See: https://mozilla-hub.atlassian.net/browse/VPN-5269?focusedCommentId=831140

@Iinh
Copy link
Contributor

Iinh commented Feb 9, 2024

Yeah it doesn't look great in JIRA I noticed. Wondering where JIRA sources their page title from, since the dictionary does have dynamically generated page title, e.g. metric/ping name.

CleanShot 2024-02-09 at 17 09 45@2x

@brizental
Copy link
Contributor Author

Huh, there you go it's a Jira bug 🤦

@wlach
Copy link
Contributor

wlach commented Mar 6, 2024

The problem is that the title is generated dynamically after the page loads. Moving to SvelteKit would fix this, but that'd be a large task: #453

Alternately, you could generate a bunch of index.html's corresponding to each path with the title (and possibly other metadata) set in each document. Also kind of painful, but probably easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants