Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Code Search" queries are not precise/helpful #2009

Open
Dexterp37 opened this issue Nov 15, 2023 · 1 comment
Open

"Code Search" queries are not precise/helpful #2009

Dexterp37 opened this issue Nov 15, 2023 · 1 comment

Comments

@Dexterp37
Copy link
Contributor

I think our code search links are broken / can be improved. For example this metric's code search links to this but it only finds tests. Something like this would work instead. The main difference is that I'm also adding just the name to the search (i.e. deviceTotalRam), leaving out the category.
The reason why this works is that in Kotlin allows to import full namespaces like that.

@chutten , thoughts?

@chutten
Copy link
Contributor

chutten commented Nov 17, 2023

That works because the unqualified name is specific enough. If it's generic, we'd see a lot of nonsense. We could filter based on the length or number of words in the metric name so we don't do it for e.g. identifier or autofilled.

Might work? Ideally we could limit this solely to metrics that might be used in Kotlin, but though we can guess that today from its presence in mozilla-mobile, that won't last for long... though we do know the application. Maybe we could have a map of app_id to known supported conjugation strategies? (and any app we haven't configured would just try them all?).

Yeah, I think there's something clever we could do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants