Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure jwe, labeled_rate, url, text fields show e.g. url, not url2 #1461

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ensure jwe, labeled_rate, url, text fields show e.g. url, not url2 #1461

wants to merge 1 commit into from
+18 −0

Conversation

Iinh
Copy link
Contributor

@Iinh Iinh commented Oct 17, 2022 •
edited

Fixes #1450.

  1. For metric types jwe, labeled_rate, url, text, show e.g. url for metric field, not url2
  2. Since for live and stable tables, the metric field has the suffix 2, add a note to clarify so.

Preview: https://deploy-preview-1461--glean-dictionary-dev.netlify.app/apps/mdn_yari/app_ids/mdn-yari/tables/action?page=1&search=metrics.url%20

CleanShot 2022-10-17 at 20 41 26@2x

@Iinh Iinh force-pushed the bug-1450 branch 2 times, most recently from 4153781 to cf66549 Compare October 17, 2022 13:27
@Iinh Iinh requested a review from fbertsch October 17, 2022 15:03
@fbertsch
Copy link
Contributor

This is exactly what we want, but unfortunately the stable table views don't do this mapping like I expected. Let me throw up a PR with that change and then we can proceed with this one.

@Iinh
Copy link
Contributor Author

Iinh commented May 5, 2023

This is exactly what we want, but unfortunately the stable table views don't do this mapping like I expected. Let me throw up a PR with that change and then we can proceed with this one.

Hi @fbertsch, any updates on ⬆️?

@Dexterp37
Copy link
Contributor

This is exactly what we want, but unfortunately the stable table views don't do this mapping like I expected. Let me throw up a PR with that change and then we can proceed with this one.

Hi @fbertsch, any updates on ⬆️?

I talked to @fbertsch , the relevant information are in this bug. Unfortunately the old PR is no longer available, so we need somebody to push this work forward before tackling this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbertsch fbertsch Awaiting requested review from fbertsch

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jwe, labeled_rate, url, and text fields should show e.g. url as the metrics field, not url2
3 participants
@Iinh @fbertsch @Dexterp37