New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Window Repositioning Broken #2042
Comments
@titusfortner we didn't change anything around |
Oh I missed that you cannot reproduce locally. Maybe you can tweak a CI run to produce some log files. That would be great. |
Let me see what I can do there. And it was definitely FF 104, always passed before, always failed after. |
Oh, I'm sorry! When I checked the list of fixed bugs I only checked these for the Marionette component but not any other. So especially for this release we had a fix as part of Firefox in https://bugzilla.mozilla.org/show_bug.cgi?id=1780212 which definitely would have caused that for you. The question now is what's wrong with restoring the window from maximized state as what it looks like to be the case here. |
I filed as https://bugzilla.mozilla.org/show_bug.cgi?id=1789823. @titusfortner do you actually have a job that doesn't run under xvfb? If yes, does it fail there as well? |
I can't duplicate the problem in my Linux VM. Even when I set |
Do you run the tests with xvfb? I wonder if that's related. |
Also do you have a chance to run the job in CI with the |
@titusfortner any further feedback? We would kinda appreciate a log for widget. |
Thanks a lot @titusfortner! Do you know if Firefox starts in fullscreen mode or if the xvfb config for GitHub doesn't have a window manager installed? Maybe that's the reason why Firefox cannot correctly determine and set a specific window state.
|
Actually when inspecting the Widget logs a bit further I can see that Firefox gets started automatically in maximized mode. So please drop that part. I'll let an engineer examine the log and hopefully we have some ideas soon. Thanks again! |
@titusfortner what is the difference to the Python jobs? They seem to work fine in CI for some of the most recent commits: https://github.com/SeleniumHQ/selenium/actions/runs/3040228998/jobs/4896101362 For these jobs there is also xvfb with |
As discovered this is only a problem when tests are run with Xvfb and no window manager installed. That's basically a not supported configuration and needs to be fixed in Selenium CI. The following pull request is open from myself that will take care of it: Given that this is not a geckodriver issue I'm closing this issue. |
FYI this issue got fixed via SeleniumHQ/selenium#11025 |
Selenium project tests started failing with Firefox v104. I only see it happening on Github, and can't reproduce it locally, even on my Linux VM.
With this code:
This is the exception:
So, the height and width were properly changed, but the x and y values were not.
https://github.com/SeleniumHQ/selenium/runs/8139181072?check_suite_focus=true#step:10:1375
The text was updated successfully, but these errors were encountered: