Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle conflicting "valid" keys better when writing to BigQuery #1298

Open
relud opened this issue May 26, 2020 · 0 comments
Open

Handle conflicting "valid" keys better when writing to BigQuery #1298

relud opened this issue May 26, 2020 · 0 comments

Comments

@relud
Copy link
Contributor

relud commented May 26, 2020

When writing to BigQuery in payload format (tables in *_live datasets), field names are normalized to snake_case, and it's currently possible to have multiple fields that map to the same normalized value, as seen in #1297 (comment).

Desired behavior: when ip and ip_ are both present the value for ip should be preserved, while ip_ should be sent to additional_properties.

Current behavior: the last successfully coerced non-null value will be preserved, and other values will only be sent to additional_properties if they failed to be coerced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant