Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to user agent for normalized_os if no os field is present #1257

Open
jklukas opened this issue Apr 21, 2020 · 0 comments
Open

Default to user agent for normalized_os if no os field is present #1257

jklukas opened this issue Apr 21, 2020 · 0 comments
Labels
pipeline metadata Should be solved by capturing new metadata in JSON schemas

Comments

@jklukas
Copy link
Contributor

jklukas commented Apr 21, 2020

In ParsePayload, we look for an OS name inside the ping using known locations for common ping, glean, and core ping. Any other payload type gets a null normalized_os value.

It would be nice to support normalized_os out of the box for structured ingestion by falling back to the OS name parsed out of the user agent string.

This may require some additional logic in NormalizeAttributes if the values we see in UA strings differ from the values reported in telemetry payloads.

@jklukas jklukas added the pipeline metadata Should be solved by capturing new metadata in JSON schemas label Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipeline metadata Should be solved by capturing new metadata in JSON schemas
Projects
None yet
Development

No branches or pull requests

1 participant