Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't connect dots unless they are adjacent in the data #339

Open
openjck opened this issue Aug 19, 2019 · 0 comments
Open

Don't connect dots unless they are adjacent in the data #339

openjck opened this issue Aug 19, 2019 · 0 comments

Comments

@openjck
Copy link
Contributor

openjck commented Aug 19, 2019

This is a rare issue that can make affected charts somewhat confusing. Imagine that a particular population is only in the data on two days: January 1, 2017 and January 1, 2019. Ensemble will show a line connecting those two points, even though that population isn't actually in the dataset for most of that time.

This can happen on the Top Languages chart. The chart shows only the top 5 languages. For some time, zh-CN and es-ES were fighting for 5th place. zh-CN overtook es-ES exactly twice: once in December 2018 and once in April 2019. It wasn't in 5th place in January, February, or March. Nonetheless, Ensemble drew a line between December 2018 and April 2019 for zh-CN, implying that it was one of the top 5 languages that whole time when it was not.

Screen Shot 2019-08-19 at 6 32 02 PM

One solution might be to show separate dots in these situations and only draw lines between dots that represent consecutive dates in the dataset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant