Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for windows modules include version in INFO line #658

Open
willkg opened this issue Oct 27, 2023 · 0 comments
Open

for windows modules include version in INFO line #658

willkg opened this issue Oct 27, 2023 · 0 comments

Comments

@willkg
Copy link
Member

willkg commented Oct 27, 2023

In bug 1861359, yannis is seeing evidence of a mismatch between a module on disk and a module in memory at the time of a crash and the minidump contains module information where the version doesn't match the code id. This leads to symbolicated stacks that are nonsense because we unwind and symbolicate with the wrong symbols file.

In order to detect this situation, it would help to include the Windows module version in an INFO line in the generated symbols file. Then the stackwalker could compare the version from the symbols file with what's in the module list stream in the minidump when processing a crash report and cry out in despair at the universe when there is a mismatch.

Maybe something like this?:

INFO MODULE_VERSION 115.0.3esr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant