BadFormatLintRule looks at tokens inside other formatting tokens which it shouldn't do

[NotSqrt]

Hi,

If I have things like "{start:%Y-%m-%d %H:%M}", I think YMHm should be considered valid.

Thanks !

[willkg]

I don't understand what you mean by this. Can you copy/paste a complete example? See #63 as an example.

[NotSqrt]

An example:

#, python-brace-format
msgid "No data between {start:%Y-%m-%d %H:%M} and {end:%Y-%m-%d %H:%M}"
msgstr "Pas de données entre le {start:%Y-%m-%d %H:%M} et le {end:%Y-%m-%d %H:%M}"

_("No data between {start:%Y-%m-%d %H:%M} and {end:%Y-%m-%d %H:%M}").format(start=date1, end=date2)

[willkg]

I tossed this into a test .po file and got this output:

E104: bad format character: %Y
0:msgstr "Pas de données entre le {start:%Y-%m-%d %H:%M} et le {end:%Y-%m-%d %H:%M}"

E104: bad format character: %m
0:msgstr "Pas de données entre le {start:%Y-%m-%d %H:%M} et le {end:%Y-%m-%d %H:%M}"

E104: bad format character: %H
0:msgstr "Pas de données entre le {start:%Y-%m-%d %H:%M} et le {end:%Y-%m-%d %H:%M}"

E104: bad format character: %M
0:msgstr "Pas de données entre le {start:%Y-%m-%d %H:%M} et le {end:%Y-%m-%d %H:%M}"

E104: bad format character: %Y
0:msgstr "Pas de données entre le {start:%Y-%m-%d %H:%M} et le {end:%Y-%m-%d %H:%M}"

E104: bad format character: %m
0:msgstr "Pas de données entre le {start:%Y-%m-%d %H:%M} et le {end:%Y-%m-%d %H:%M}"

E104: bad format character: %H
0:msgstr "Pas de données entre le {start:%Y-%m-%d %H:%M} et le {end:%Y-%m-%d %H:%M}"

E104: bad format character: %M
0:msgstr "Pas de données entre le {start:%Y-%m-%d %H:%M} et le {end:%Y-%m-%d %H:%M}"

The BadFormatLintRule shouldn't be looking at formatting tokens inside of other formatting tokens. I'll have to think about this.

[willkg]

That fixes this specific issue and should fix the general problem, too. In working on this, I found another problem with translators that requires a minor rewrite. That's covered in #67. I need to fix that before I do another release.

[NotSqrt]

Thanks @willkg !