Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint summary assumes too much about path names #12

Open
willkg opened this issue Jul 9, 2013 · 0 comments
Open

lint summary assumes too much about path names #12

willkg opened this issue Jul 9, 2013 · 0 comments
Labels

Comments

@willkg
Copy link
Member

willkg commented Jul 9, 2013

The lint summary assumes that the paths are in the form locale/xx/LC_MESSAGES/messages.po. If that's true, then it prints out a summary like this:

Final Tally:

Number of files examined:            160
Total number of files with errors:    57
Total number of warnings:           1479
Total number of errors:              781

Warnings  Errors  Filename
    81        67  en_US (messages.po)
    28        46  lt (messages.po)
    26        42  th (messages.po)
    30        41  tr (messages.po)
    62        40  eu (messages.po)
    25        40  id (messages.po)
    30        39  hr (messages.po)
    57        37  fy_NL (messages.po)

If that's not true, then it prints a summary that's goofy looking. For example, with Miro, it prints this:

Final Tally:

Number of files examined:             91
Total number of files with errors:    18
Total number of warnings:            101
Total number of errors:               37

Warnings  Errors  Filename
     2         5  resources (tr.po)
     0         4  resources (ko.po)
     4         3  resources (lv.po)
     0         3  resources (zh_TW.po)
     0         3  resources (zh_CN.po)
     0         3  resources (th.po)
     0         3  resources (sl.po)
     3         2  resources (br.po)
     0         2  resources (id.po)

We could print the entire path, but paths can be really long, so I'm not excited about that. We could print the last part of the path, but that might not be enough information. We could use CLDR information to divine the locale from the path parts. Maybe that's the right thing to do.

@willkg willkg modified the milestone: v0.9 fix the parsing pipeline Jan 4, 2017
@willkg willkg removed this from the v0.10 clean up project milestone May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant