Skip to content
This repository has been archived by the owner on May 27, 2021. It is now read-only.

Warning from eslint-plugin-react about version #674

Closed
peterbe opened this issue Dec 28, 2018 · 1 comment
Closed

Warning from eslint-plugin-react about version #674

peterbe opened this issue Dec 28, 2018 · 1 comment

Comments

@peterbe
Copy link
Contributor

peterbe commented Dec 28, 2018 

Warning: React version not specified in eslint-plugin-react settings. See https://github.com/yannickcr/eslint-plugin-react#configuration.

I suspect this happened since this upgrade.
@peterbe
Copy link
Contributor Author

peterbe commented Dec 28, 2018

I can't map the configuration examples to our settings.
The warnings seems pretty benign though since it just means poor eslint-plugin-react has to assume we're running the latest version of react.
Suppose we find the exact place to put the react version in our config (in package.json??) we'd have to maintain that to match the version of react in package.json every time.

mythmon added a commit to mythmon/delivery-console that referenced this issue Jan 7, 2019
@mythmon
Configure eslint-plugin-react to auto-detect React version
09ca96e 
Fixes mozilla#674
@mythmon mythmon mentioned this issue Jan 7, 2019
Merged
bors bot added a commit that referenced this issue Jan 8, 2019
@bors @mythmon
Merge #695
b5303b5 
695: Configure eslint-plugin-react to auto-detect React version r=rehandalal a=mythmon

Fixes #674

Co-authored-by: Mike Cooper <mythmon@gmail.com>
@bors bors bot closed this as completed in #695 Jan 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peterbe