Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect (outdated?) fetch_all_dependencies config suggestion #936

Open
rockboynton opened this issue Apr 1, 2024 · 2 comments
Open

Incorrect (outdated?) fetch_all_dependencies config suggestion #936

rockboynton opened this issue Apr 1, 2024 · 2 comments

Comments

@rockboynton
Copy link

When parsing deps fails I get the following suggestions:

Parsing crate `strum_macros`: can't find lib.rs with `cargo metadata`. The crate may be available only on a particular platform, so consider setting `fetch_all_dependencies` in your cbindgen configuration.

fetch_all_dependencies doesn't appear anywhere in the codebase besides this error message currently.

@rockboynton rockboynton changed the title Incorrect (outdated?) config suggestion Incorrect (outdated?) fetch_all_dependencies config suggestion Apr 1, 2024
@emilio
Copy link
Collaborator

emilio commented Apr 14, 2024

Ugh, yeah, so this is from 93c06c5. The warning mentions the original option name, but it landed with the name flipped (only_target_dependencies) and off-by-default, and I overlooked that when reviewing.

So the (bad?) news is that unless you're using only_target_dependencies=true that's not the source of the problem.

So:

  • Fixing the warning message seems worth it, but...
  • Your problem probably needs some sort of repro to investigate.

Thanks!

@rockboynton
Copy link
Author

Hi, @emilio, thank you for looking in to this.

You're correct that it wasn't actually the source of the problem, and I don't have this issue anymore 🤷🏻‍♂️ so I don't remember the cause...maybe someone else will into a similar issue and can comment, or I will if I see this again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants