Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support converting Rust <name>: ... to C ... (varargs) #894

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support converting Rust <name>: ... to C ... (varargs) #894

wants to merge 1 commit into from

Conversation

4lDO2
Copy link

@4lDO2 4lDO2 commented Oct 29, 2023

Fixes #891.

I made this configurable, but I'm not sure if that's correct. Should ... be the default, or only accepted translation, given Rust supports both va: ... and va: VaList for those two purposes?

emilio
emilio requested changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could simplify this to always generate the same code I think that'd be preferable. Otherwise let's update the docs to reflect the new options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio emilio requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correctly parsing c variadics args: ...
2 participants
@4lDO2 @emilio