Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move requirements in requirements-dev.in to setup.py #620

Closed
willkg opened this issue Dec 2, 2021 · 2 comments
Closed

move requirements in requirements-dev.in to setup.py #620

willkg opened this issue Dec 2, 2021 · 2 comments
Milestone

Comments

@willkg
Copy link
Member

willkg commented Dec 2, 2021

In my other projects, I've moved all the dev requirements into setup.py as extras_require. I think we should do that here, too. It changes the developer workflow to something like this:

pip install '.[dev]'

Then we don't need pip-tools (which isn't listed as a dependency anywhere).

@willkg willkg added this to the v5.0.0 milestone Feb 8, 2022
@g-k
Copy link
Collaborator

g-k commented Feb 8, 2022

Sound good!

We should update any dev setup and the release process docs to use that package name and call out the package as project internal / unstable API. Version-wise I assume it'd match the non-dev bleach version

willkg added a commit that referenced this issue Feb 10, 2022
@willkg
Copy link
Member Author

willkg commented Feb 10, 2022

This is fixed in #640.

@willkg willkg closed this as completed Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants