Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove six from dependencies #618

Open
sevdog opened this issue Nov 11, 2021 · 4 comments
Open

remove six from dependencies #618

sevdog opened this issue Nov 11, 2021 · 4 comments

Comments

@sevdog
Copy link

sevdog commented Nov 11, 2021

Since support for Python 2 was removed in version 2.0 the use of SIX library to handle compatibility between Python 3 and Python 2 has no more meaning (aka: it is a useless dependecy).

See remaining code using SIX.

@g-k
Copy link
Collaborator

g-k commented Nov 11, 2021

Happy to accept a PR for this and I'll leave this open to track the issue.

Keep in mind we don't want to edit the vendored html5lib since we'd effectively fork it. Last I checked this would require an upstream release of html5lib.

@g-k g-k changed the title remove six from dependecies remove six from dependencies Nov 11, 2021
@sevdog
Copy link
Author

sevdog commented Nov 11, 2021

Now that you mention it, this could be a problem since six is only used in vendored html5lib 🥲

Before rebasing that folder this PR should be merged by them.

@willkg willkg added this to the v5.0.0 milestone Feb 8, 2022
@willkg
Copy link
Member

willkg commented Feb 8, 2022

I put this in the 5.0.0 milestone because I thought we could do it, but we can't, yet. We're blocked on upstream dropping the need for six.

@willkg willkg removed this from the v5.0.0 milestone Feb 8, 2022
@g-k g-k added the html5lib label Apr 30, 2022
@willkg
Copy link
Member

willkg commented Oct 27, 2022

It seems like upstream is no longer maintained. The PR in question was closed. Issue #680 covers forking html5lib or finding an alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants