Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations #477

Closed
3 tasks
g-k opened this issue Sep 9, 2019 · 2 comments
Closed
3 tasks

Add type annotations #477

g-k opened this issue Sep 9, 2019 · 2 comments

Comments

@g-k
Copy link
Collaborator

g-k commented Sep 9, 2019

We could:

Annotations would have to be in comment form to maintain backwards compatibility with Python 2, but we can skip that if #520 lands first.

@mastizada
Copy link
Contributor

In 2 month and 15 days Python2 will be retired and using it will be a security issue by itself (https://pythonclock.org/). I think it will be ok to use Python 3 only annotation after this period.

@g-k g-k changed the title Add type annotations? Add type annotations Sep 16, 2020
@g-k g-k added this to the v4.0.0 milestone Sep 16, 2020
This was referenced Jan 25, 2021
@willkg willkg removed this from the v5.0.0 milestone Apr 7, 2022
@willkg
Copy link
Member

willkg commented Oct 6, 2023

We deprecated this project, so we're not going to implement more features.

@willkg willkg closed this as completed Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants