Fix doctest failures #433
Merged
Fix doctest failures #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reworks the doctests to run and pass in Python 3. Fixes #357
willkg
commented
Jan 8, 2019
| @@ -353,7 +353,7 @@ Trivial Filter example: | |||
| .. doctest:: | |||
|
|
|||
| >>> from bleach.sanitizer import Cleaner | |||
| >>> from html5lib.filters.base import Filter | |||
| >>> from bleach.html5lib_shim import Filter | |||
There was a problem hiding this comment.
This one is interesting. What's going on is that we vendored html5lib, so it's no longer installed as a requirement. That's cool, but that means it's not installed anymore. I switched it to use the bleach.html5lib_shim module. It's the same Filter class, but it's specifically the one that ships with Bleach. That's more correct. I'm not sure if it feels weird to be importing it from a module named bleach.html5lib_shim or not. It's probably fine.
g-k
approved these changes
Jan 9, 2019
| @@ -353,7 +353,7 @@ Trivial Filter example: | |||
| .. doctest:: | |||
|
|
|||
| >>> from bleach.sanitizer import Cleaner | |||
| >>> from html5lib.filters.base import Filter | |||
| >>> from bleach.html5lib_shim import Filter | |||
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks the doctests to run and pass in Python 3.
Fixes #357