Fix parsing "meta" tag with encoding attribute #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing a <meta encoding=""> tag, the parser calls charEncoding and changeEncoding in the input stream, but the InputStreamWithMemory wrapper didn't have those methods. This fixes that. This also creates a new test set for BleachHTMLParser functionality. Fixes #431
willkg
commented
Jan 8, 2019
| @@ -1,7 +1,7 @@ | |||
| Bleach changes | |||
| ============== | |||
|
|
|||
| Version 3.0.3 (In development) | |||
| Version 3.1.0 (In development) | |||
There was a problem hiding this comment.
We're adding backwards-compatible API changes, so this needs to be a MINOR increment rather than a PATCH increment.
willkg
commented
Jan 8, 2019
| @@ -25,6 +25,12 @@ None | |||
| * Fix cases where attribute names could have invalid characters in them. | |||
| (#419) | |||
|
|
|||
| * Fix problems with ``LinkifyFilter`` not being able to match links | |||
| across ``&``. (#422) | |||
There was a problem hiding this comment.
I should have added this in the last PR.
willkg
commented
Jan 8, 2019
| @@ -80,3 +80,65 @@ def test_serializer(data, expected): | |||
| serialized = serializer.render(walker(dom)) | |||
|
|
|||
| assert serialized == expected | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize('parser_args, data, expected', [ | |||
There was a problem hiding this comment.
This tests the specific issue here plus other interesting BleachHTMLParser behavior.
willkg
commented
Jan 8, 2019
| {}, | ||
| '<a href=\'http://example.com\'\'>', | ||
| '<a href="http://example.com"></a>' | ||
| ) |
There was a problem hiding this comment.
We had a LinkifyFilter test that tested this. I nixed that test and moved the relevant parts here where they're not encumbered by LinkifyFilter things.
willkg
commented
Jan 8, 2019
| '<a href="http://example.com/" rel="nofollow"></a>' | ||
| ) | ||
|
|
||
|
|
There was a problem hiding this comment.
The important part of this got moved to the BleachHTMLParser tests.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing a tag, the parser calls charEncoding
and changeEncoding in the input stream, but the InputStreamWithMemory
wrapper didn't have those methods. This fixes that.
This also creates a new test set for BleachHTMLParser functionality.
Fixes #431