Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check each throttle class before returning a 429 response in signing view #6774

Closed
diox opened this issue Jul 2, 2019 · 4 comments
Closed

Comments

@diox
Copy link
Member

diox commented Jul 2, 2019

If a single throttling class disallows the request, the other throttling classes never see the request and it never gets added to their history. That means essentially the throttling classes after the first one that failed don't count some requests towards their limit.

I submitted an issue and pull request to DRF fixing this (encode/django-rest-framework#6667), it was merged but hasn't been released yet, so let's backport it.

See also #6655

@EnTeQuAk
Copy link
Contributor

There is a new release that contains this fix out now.

@EnTeQuAk
Copy link
Contributor

Actually, it might not be it yet… mozilla/addons-server#11899 (comment)

@EnTeQuAk
Copy link
Contributor

@diox
Copy link
Member Author

diox commented Sep 5, 2019

We just merged mozilla/addons-server#12273 which updates our DRF to 3.10.3, and that should have both my patch and @EnTeQuAk 's fix.

@diox diox closed this as completed Sep 5, 2019
@KevinMind KevinMind transferred this issue from mozilla/addons-server May 4, 2024
@KevinMind KevinMind added repository:addons-server Issue relating to addons-server migration:2024 labels May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants