Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check each throttle class before returning a 429 response in signing view #11765

Closed
diox opened this issue Jul 2, 2019 · 4 comments
Closed

Check each throttle class before returning a 429 response in signing view #11765

diox opened this issue Jul 2, 2019 · 4 comments
Assignees
@diox
Labels
component:api

Comments

@diox
Copy link
Member

diox commented Jul 2, 2019

If a single throttling class disallows the request, the other throttling classes never see the request and it never gets added to their history. That means essentially the throttling classes after the first one that failed don't count some requests towards their limit.

I submitted an issue and pull request to DRF fixing this (encode/django-rest-framework#6667), it was merged but hasn't been released yet, so let's backport it.

See also #11393
@diox diox added this to the 2019.07.11 milestone Jul 2, 2019
@diox diox self-assigned this Jul 2, 2019
@diox diox mentioned this issue Jul 3, 2019
Open
@eviljeff eviljeff removed this from the 2019.07.11 milestone Jul 17, 2019
@EnTeQuAk
Copy link
Contributor

There is a new release that contains this fix out now.

@EnTeQuAk
Copy link
Contributor

Actually, it might not be it yet… #11899 (comment)

@EnTeQuAk
Copy link
Contributor

encode/django-rest-framework#6836 with upstream PR encode/django-rest-framework#6837

@diox
Copy link
Member Author

diox commented Sep 5, 2019

We just merged #12273 which updates our DRF to 3.10.3, and that should have both my patch and @EnTeQuAk 's fix.

@diox diox closed this as completed Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diox diox

Labels
component:api
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@EnTeQuAk @diox @eviljeff