Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit helpful message when background.service_worker is used without background.scripts/page #5252

Open
Rob--W opened this issue Apr 11, 2024 · 0 comments

Comments

@Rob--W
Copy link
Member

Rob--W commented Apr 11, 2024

addons-linter was patched before to emit only a warning when background.service_worker is used without scripts/page (#5152). The warnings are still not very helpful.

Instead of a generic "/background/service_worker" is not supported.", we should print a helpful message that encourages the use of scripts. For more details on why and what, see my write-up for web-ext run at mozilla/web-ext#3101

The relevant implementation was last touched for #5152, at

this.collector.addWarning(
messages.manifestFieldUnsupported('/background/service_worker')
);
} else {
this.collector.addError(
messages.manifestFieldUnsupported('/background/service_worker')
);
this.isValid = false;
}

┆Issue is synchronized with this Jira Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant