Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize is included in the middle of the CSS bundle #10988

Closed
muffinresearch opened this issue Oct 18, 2017 · 5 comments · Fixed by mozilla/addons-frontend#5795
Closed

Normalize is included in the middle of the CSS bundle #10988

muffinresearch opened this issue Oct 18, 2017 · 5 comments · Fixed by mozilla/addons-frontend#5795

Comments

@muffinresearch
Copy link
Contributor

Since our style is fairly heavily specified I'm not sure how much this is a problem but normalize is not currently included at the top of our stylesheet.

@muffinresearch
Copy link
Contributor Author

Looks like there's various issues reportd on webpack the text-extractor plugin related to this. It'll need further investigation but the problem probably lies within that or how we've got things configured.

@willdurand
Copy link
Member

It looks like the order is inverted because the fonts, normalize and App/styles.scss are at the bottom of the stylesheet while .Card-header is at the top (it is not the first component rendered).

@willdurand
Copy link
Member

ahm, I think I found the issue, more info at: webpack-contrib/extract-text-webpack-plugin#548.

TL;DR: we always import './styles.scss' after the JS imports, which means the SCSS/CSS imports in App/index.js are the last ones being imported. I believe it should always been imported after except for the App components.

@willdurand
Copy link
Member

For QA: please make sure the website still uses the CSS style. If you like, you could look at the .css file source code and see the first lines starting with @font-face ....

@willdurand willdurand added this to the 2018.08.02 milestone Jul 31, 2018
@vcarciu
Copy link

vcarciu commented Aug 1, 2018

Verified as fixed :
css

@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 5, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants