Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the "not actively monitored" banner on Android as well #2207

Closed
wagnerand opened this issue Jan 26, 2024 · 5 comments · Fixed by mozilla/addons-frontend#13010
Closed

Show the "not actively monitored" banner on Android as well #2207

wagnerand opened this issue Jan 26, 2024 · 5 comments · Fixed by mozilla/addons-frontend#13010
Assignees
@diox
Labels
qa:verified_fix repository:addons-frontend Issue relating to addons-frontend
Milestone
2024.05.30

Comments

@wagnerand
Copy link
Member

wagnerand commented Jan 26, 2024 •
edited by data-sync-user

Describe the problem and steps to reproduce it:

If I am reading https://github.com/mozilla/addons-frontend/blob/dbaccfefecebb538e9ea5462c7fed9fd7c971849/src/amo/components/InstallWarning/index.js#L89 right...

What happened?

...we are not showing the "not actively monitored" banner on android at all.

What did you expect to happen?

...we should show that banner, under the same (other) conditions like we do on desktop.

Anything else we should know?

┆Issue is synchronized with this Jira Task
@KevinMind
Copy link
Contributor

Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDFRNT-326

@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 3, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 3, 2024
@abyrne-moz
Copy link

This refers to the banner in the screenshot.
image

On Desktop, this is used as a differentiator between some add-ons Add-ons Operations have pre-reviewed (for example Recommended Extensions) and the rest. That means when the banner is not shown, users know this is safe to install.
If this banner is not present for any extension on Android, users might mistakenly assume the add-on they look at has been reviewed

@diox diox added this to the 2024.05.30 milestone May 15, 2024
@diox diox self-assigned this May 15, 2024
@diox
Copy link
Member

diox commented May 16, 2024

Some background: back when we introduced that banner, we ran an experiment first to see the impact. At the time, we only showed recommended add-ons on Android, so this banner was not necessary there, and including Android users in the experiment was skewing the data. So we explicitly prevented it from being shown on Android in #13410.

Now that we have general availability of add-ons on Android we should show the banner here as well for consistency as explained in #2207 (comment)

@diox diox mentioned this issue May 16, 2024
Merged
@KevinMind
Copy link
Contributor

Would have been good to include a screenshot of what you should expect to see.

image

@ioanarusiczki
Copy link

Verified on AMO dev - I tried with UA Mozilla/5.0 (Android 14; Mobile; rv:128.0) Gecko/128.0 Firefox/128.0

From a Redmi Note 4 with Android 7.0

from small device

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diox diox

Labels
qa:verified_fix repository:addons-frontend Issue relating to addons-frontend
Projects
None yet
Milestone
2024.05.30
Development

Successfully merging a pull request may close this issue.

Show the "not actively monitored" banner on Android as well diox/addons-frontend
5 participants
@diox @wagnerand @KevinMind @ioanarusiczki @abyrne-moz