Feature/changes in colander validation #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dator, check for MappingSchema instance
…es-in-colander-validation
|
I had the same issue in my app. I am going to borrow your fork after merging with current master and use in my code. Thanks. |
|
My bad, I really missed this PR :( |
|
so @leplatrem are you going to merge this? |
leplatrem
approved these changes
Dec 2, 2019
|
I released 4.0 with this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@leplatrem I thought it is better to explicitly raise an error with a meaningful message rather than just fail with ValueError (on call
request.validated.update(some_non_empty_list)) when schema is not an instance ofcolander.MappingSchema. What do you think? #503