Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for versions below Node.js 6 #108

Closed
Siilwyn opened this issue Oct 23, 2018 · 6 comments
Closed

Drop support for versions below Node.js 6 #108

Siilwyn opened this issue Oct 23, 2018 · 6 comments

Comments

@Siilwyn
Copy link
Contributor

Siilwyn commented Oct 23, 2018

Something for the future, I was looking into reducing my CLI tool size and noticed the semver package at the top when sorting by size.

When going with Node.js 6 and higher two dependencies, semver and nice-try are not needed anymore since they are used only once for feature detection here:

const supportsShellOption = niceTry(() => semver.satisfies(process.version, '^4.8.0 || ^5.7.0 || >= 6.0.0', true)) || false;

@satazor
Copy link
Contributor

satazor commented Mar 13, 2019

Node 6 is reaching EOL in April. In May, I will remove both node 4 and 6 support in a single release.

@ehmicky
Copy link
Contributor

ehmicky commented Jun 14, 2019

@satazor, any news on this? Thanks!

@satazor
Copy link
Contributor

satazor commented Aug 19, 2019

It’s time to remove support for older Node versions. @Siilwyn @ehmicky want to give this a try?

@Siilwyn
Copy link
Contributor Author

Siilwyn commented Aug 19, 2019

@satazor #125

@satazor
Copy link
Contributor

satazor commented Aug 20, 2019

#125 was merged!

@satazor satazor closed this as completed Aug 20, 2019
@satazor
Copy link
Contributor

satazor commented Aug 20, 2019

I will release a new version in the next hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants