feature: added array/repeat. #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roboshoes
reviewed
Nov 8, 2019
Comment on lines
+13
to
+19
| it('should create an array of size N and fill with a value "a".', function(){ | ||
| expect(repeat(2, 'a')).toEqual(['a', 'a']); | ||
| }); |
There was a problem hiding this comment.
Would you mind also adding some tests with longer strings as well as numbers?
There was a problem hiding this comment.
Added a test for the longer string and using a number.
|
I think we just need to extend the test cases a bit further but other than that I think it's good. |
|
Sure. I'll add both tests. Thanks, @roboshoes. |
|
Thank you. |
|
I've merged you're contribution and it's live on 1.2.2. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.