Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream timeout #15

Closed
mountainflo opened this issue Jan 5, 2020 · 1 comment · Fixed by #19
Closed

stream timeout #15

mountainflo opened this issue Jan 5, 2020 · 1 comment · Fixed by #19
Labels
bug Something isn't working go lang contains work with Golang javascript Contains work with Javascript
Projects
Project Board

Comments

@mountainflo
Copy link
Owner

mountainflo commented Jan 5, 2020 •
edited

Problem
The Server-side stream which serves the updates to all clients automatically closes after some time with the message "stream timeout". No automatic reconnection of the stream is happening.

Possible Solution
It would be an idea to send keep-alive pings from time to time from the go server to the clients.
@mountainflo mountainflo added the bug Something isn't working label Jan 5, 2020
@mountainflo mountainflo added this to To do in Project Board via automation Jan 5, 2020
@mountainflo mountainflo added go lang contains work with Golang javascript Contains work with Javascript labels Jan 5, 2020
@mountainflo
Copy link
Owner Author

Issue: grpc/grpc-go#3093
Keepalive Feature: https://github.com/grpc/grpc-go/tree/master/examples/features/keepalive

mountainflo pushed a commit that referenced this issue Jan 15, 2020
#15 fix envoy timeout
4f378b2
mountainflo pushed a commit that referenced this issue Jan 15, 2020
#15 reconnection after interruption or connection failure
343f6a6
@mountainflo mountainflo mentioned this issue Jan 15, 2020
Merged
Project Board automation moved this from To do to Done Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working go lang contains work with Golang javascript Contains work with Javascript
Projects
Project Board
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix/timeout and reconnection mountainflo/collaborative-text-editor
1 participant
@mountainflo