Parse \r line endings (mac) #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbeatty
suggested changes
Aug 15, 2019
|
released in v8.1.0 |
|
I wasted a long time debugging my code 😡
|
|
@nmaxcom |
|
Nope. I created this project a few weeks ago and this is how it stands in my package.json: "dotenv": "^8.0.0" I am grateful for this package, but I don't understand the low level of parsing up to version 8.1.0 |
This was referenced Mar 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #409 by finding all three EOL types (\n, \r, \r\n) and replacing it with the NEWLINE variable, currently being the Unix standard.
When i run
npm testi get backError: test count exceeds plan.I have not used TAP to write tests before but i assume i need a plan to run the tests locally. However if i deliberately break the test it shows a different error, so im assuming the test works.
@maxbeatty