Support HTTP Trailers in http and http2 packages #2145
Comments
|
good job， PR welcome ~ |
|
@taoyuanyuan before I start, I have a question. Currently, mosn is using go 1.14 which is very long since unsupported. I'm concerned that newer dependencies aren't really made to work with that version of go. Is it possible to upgrade it? If so, I'll do a PR in another change first (currently supported go is 1.18-1.19) https://go.dev/doc/devel/release#policy |
|
@codefromthecrypt we could upgrade to go 1.18, welcome~ |
|
@taoyuanyuan @antJack PS right now mosn is working with a new http wasm middleware system we're writing, despite trailers not being supported yet. here are some notes if you are interested on the current progress. I'd love some advice on our mosn impl which is our host repo until our api stabalizes. After that, maybe we can make a repo here like exists for proxy-wasm and you can have a CGO-free wasm extension system. http-wasm/http-wasm#2 (comment) |
|
status update: api and pkg are now up to latest versions, but I need to update the pkg with the trailer apis before versions should be cut there. afterwards we need those versions aligned first in holmes, then mosn itself to move forward See mosn/pkg#66 |
The New Feature
Right now, HTTP trailers are not yet supported for reasons including mosn using an old version of fasthttp.
Your scenes
Without full support for trailers, apps can crash or not know when a proxied server sends them.
Your advice
Update mosn to latest fasthttp and complete the change. I've attached an incomplete diff as I ran into trouble trying this.
valyala/fasthttp#1165
mosn-trailers.zip
PS thanks to @anuraaga for help identifying the problem.
Environment
The text was updated successfully, but these errors were encountered: