Skip to content

Clusters docs #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 25, 2020
Merged

Clusters docs #448

merged 2 commits into from
Feb 25, 2020
+23 −3

Conversation

robertsLando
Copy link
Member

@robertsLando
Clusters docs #436

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
8dd88a0
@robertsLando robertsLando requested a review from gnought February 24, 2020 10:56
@github-actions
Copy link

Pull Request Test Coverage Report for Build afbac3d9e89c185925be0adb2bc6330011cdbd6e-PR-448

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.72%
Totals Coverage Status
Change from base Build fc45bc6cc9bbf01443e6670f2c593dcd280bf20b: 0.0%
Covered Lines: 762
Relevant Lines: 762
💛 - Coveralls

@gnought
Copy link
Collaborator

gnought commented Feb 24, 2020

Could it be in Examples.md?

@robertsLando
Copy link
Member Author

robertsLando commented Feb 24, 2020 •
edited
Loading

@gnought Clusters is a main feature for Aedes and I think it is worth keep it in main readme.

I could move it from a sub-section of examples to a main section, lot peoples are looking for them

@gnought
Copy link
Collaborator

gnought commented Feb 24, 2020

You have already mentioned it as a feature, you could set a link pointing into examples.md

@robertsLando
Moved clusters to Exampes.md

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
f92cca5
@robertsLando
Copy link
Member Author

@gnought Modified

gnought
gnought approved these changes Feb 25, 2020
View reviewed changes
Copy link
Collaborator

@gnought gnought left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
Put it there first. We may go into this topic in more details.

@robertsLando robertsLando merged commit aaa5f0b into master Feb 25, 2020
@robertsLando robertsLando deleted the docs branch February 25, 2020 12:49
@snyk-bot snyk-bot mentioned this pull request Apr 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnought gnought

@mcollina mcollina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@robertsLando @gnought