Skip to content

Update main.ts #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 25, 2022
Merged

Conversation

talboren
Copy link
Contributor

To allow debugging this issue: #266

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@MorrisonCole
Copy link
Owner

MorrisonCole commented Feb 24, 2022

Hi @talboren - (you may be doing this already but) there are a few repositories using the main branch directly so I'd recommend doing any debugging against your fork (e.g., update your workflow step to point at this branch) - syntax for pointing at commits/branches

(Edit: and apologies, it's 10:30 pm in my time zone but in general, I'll take a look at the issue/any PRs tomorrow 🙏 !)

@talboren
Copy link
Contributor Author

Hi @talboren - (you may be doing this already but) there are a few repositories using the main branch directly so I'd recommend doing any debugging against your fork (e.g., update your workflow step to point at this branch) - syntax for pointing at commits/branches

(Edit: and apologies, it's 10:30 pm in my time zone but in general, I'll take a look at the issue/any PRs tomorrow 🙏 !)

Done, also tested it and it seems to be working 💪🏼
Don't know if the solution looks good to you so let me know wdyt.

Thanks!

@MorrisonCole
Copy link
Owner

MorrisonCole commented Feb 25, 2022

Thanks, @talboren - I understand what the issue was now and the solution LGTM! I'll just merge & re-package this and get it merged shortly.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.
@MorrisonCole MorrisonCole merged commit 9f55d33 into MorrisonCole:main Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants