From 0bbaddc210a28c493fae7bebf37e234fd1915fb6 Mon Sep 17 00:00:00 2001 From: chrisymassie Date: Sat, 28 Aug 2021 15:13:32 -0700 Subject: [PATCH] switch to using processor count instead of physical see https://github.com/grosser/parallel/issues/300 it seems to be faster and it is the same as parallel_tests uses --- lib/parallel_split_test.rb | 6 +----- spec/parallel_split_test_spec.rb | 8 +------- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/lib/parallel_split_test.rb b/lib/parallel_split_test.rb index 0084235..63023c4 100644 --- a/lib/parallel_split_test.rb +++ b/lib/parallel_split_test.rb @@ -14,11 +14,7 @@ def choose_number_of_processes end def best_number_of_processes - [ - ENV['PARALLEL_SPLIT_TEST_PROCESSES'], - Parallel.physical_processor_count, - Parallel.processor_count - ].map(&:to_i).find{|number| number > 0 } + Integer(ENV['PARALLEL_SPLIT_TEST_PROCESSES'] || Parallel.processor_count) end end end diff --git a/spec/parallel_split_test_spec.rb b/spec/parallel_split_test_spec.rb index d256eca..46eac9e 100644 --- a/spec/parallel_split_test_spec.rb +++ b/spec/parallel_split_test_spec.rb @@ -17,13 +17,7 @@ expect(count).to eq(5) end - it "uses physical_processor_count" do - allow(Parallel).to receive(:physical_processor_count).and_return 6 - expect(count).to eq(6) - end - - it "uses processor_count if everything else fails" do - allow(Parallel).to receive(:physical_processor_count).and_return 0 + it "uses processor_count" do allow(Parallel).to receive(:processor_count).and_return 7 expect(count).to eq(7) end