Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hour and minute precision #290

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Add hour and minute precision #290

wants to merge 12 commits into from

Conversation

morewings
Copy link
Owner

Fixes #234

@morewings morewings added this to the 0.5.0 milestone Jan 4, 2021
@morewings morewings mentioned this pull request Jan 5, 2021
Open
@morewings morewings force-pushed the precision branch 2 times, most recently from 1619b9e to a8960ca Compare February 20, 2021 11:11
@codecov
Copy link

codecov bot commented Feb 20, 2021 •
edited

Codecov Report

Merging #290 (794dcf2) into master (09c9241) will decrease coverage by 3.53%.
The diff coverage is 70.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
- Coverage   95.00%   91.46%   -3.54%     
==========================================
  Files          59       64       +5     
  Lines         500      609     +109     
  Branches       79      102      +23     
==========================================
+ Hits          475      557      +82     
- Misses         25       42      +17     
- Partials        0       10      +10
Impacted Files Coverage Δ
src/environment/App/App.js 42.85% <ø> (-14.29%) ⬇️
src/lib/components/logic/Calendar/Calendar.js 100.00% <ø> (ø)
src/lib/components/logic/Selector/Selector.js 100.00% <ø> (ø)
src/lib/features/locale/useLocaleEnumerators.js 100.00% <ø> (ø)
src/lib/utils/defaultTheme.js 100.00% <ø> (ø)
src/lib/components/logic/Clock/Clock.js 51.11% <51.11%> (ø)
src/lib/components/visual/Selector/Selector.js 91.66% <60.00%> (-8.34%) ⬇️
src/lib/components/visual/Clock/Clock.js 61.11% <61.11%> (ø)
src/lib/utils/enumerators.js 96.00% <92.00%> (-4.00%) ⬇️
src/lib/components/Datepicker/Datepicker.js 100.00% <100.00%> (+4.16%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09c9241...794dcf2. Read the comment docs.

morewings and others added 2 commits February 20, 2021 19:17
@morewings
clean up
7b4a06a
@morewings
Update react-scripts and fix tests (#337)
794dcf2 
* update + start

* WIP

* update

* fix tests

* WIP

* WIP

* WIP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

Add hours and minutes precision
1 participant
@morewings