Allow passing before_and_after remainders into before_and_after again #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gleb-akhmerov
changed the title
bbayles
approved these changes
Oct 15, 2022
|
Nice solution! |
bbayles
requested changes
Oct 15, 2022
Co-authored-by: Bo Bayles <bbayles@gmail.com>
|
Ah, now |
|
Are magic numbers okay in this case? |
|
Yeah, looks like just a long line left. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue reference
#649
Changes
This PR allows to pass the remainder of
before_and_afterintobefore_and_afteragain without triggering aRecursionError. See the linked issue and the new test for more info.