Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove include_package_data option from setup.py to fix type stubs not included in sdist. #554

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Remove include_package_data option from setup.py to fix type stubs not included in sdist. #554

merged 1 commit into from
Sep 14, 2021

Conversation

saaketp
Copy link
Contributor

@saaketp saaketp commented Sep 14, 2021 •
edited

Issue reference

#553

Changes

Remove include_package_data option from setup.py
The package_data option will be used for both sdist and bdist with this change.

@saaketp
Remove include_package_data option from setup.py
b43a1ee 
The `include_package_data` is not required when `package_data`
is specified in setup.
It just causes problems when building sdists
because the package_data is ignored and a repeat entry of
the package_data items is required in MANIFEST.in
@saaketp
Copy link
Contributor Author

saaketp commented Sep 14, 2021

I removed the change in MANIFEST.in, the correct files were not included in the sdist actually if MANIFEST.in is removed.
Earlier when I though the correct files were being included, it was by mistake because of a previous build in the same folder.

So now this is just that one line change.

@bbayles bbayles linked an issue Sep 14, 2021 that may be closed by this pull request
The sdist doesn't contain type stubs #553
Closed
@bbayles bbayles merged commit 2129549 into more-itertools:master Sep 14, 2021
@saaketp
Copy link
Contributor Author

saaketp commented Sep 15, 2021

Thanks @bbayles .
Now have to wait for a new release to get type stubs in the conda-forge build.
Can there be a new release soon?

@saaketp saaketp deleted the sdist-fix branch September 15, 2021 08:49
@bbayles
Copy link
Collaborator

bbayles commented Sep 17, 2021

Here is the release:
https://github.com/more-itertools/more-itertools/releases/tag/v8.10.0

@saaketp
Copy link
Contributor Author

saaketp commented Sep 18, 2021

Thanks, it landed in conda-forge too now.
And it works well, no complaints about missing type stubs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The sdist doesn't contain type stubs
2 participants
@saaketp @bbayles