Mock.Of<Class> shouldn't delete invocations made from Class' ctor
#980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One side effect of `FluentMockVisitor` (recently removed) was that it caused extra invocations to be recorded during mock setup. We then had to delete that record to give off the impression that new mocks are truly untouched. Unfortunately, this also caused invocations to be cleared that should have stayed in the record. We no longer use `FluentMockVisitor`, so no extra invocations are re- corded in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hack introduced by yours truly in #543 has introduced inconsistent behavior between
new Mock<T>()andMock.Of<T>(): The latter will clear all invocations from the mock'sInvocationscollection — not just those caused by the library itself (as was intended), but also those caused by user code.We can now safely remove that hack since we no longer use
FluentMockVisitor(which was the component causing extraneous invocations).