Improve error message when verification fails #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakx
approved these changes
Feb 2, 2021
|
|
||
| var mex = Assert.Throws<MockException>(() => mock.Verify()); | ||
| Assert.True(mex.IsVerificationError); | ||
| Assert.Contains(@".Execute(It.Is<string>(s => s == password)", mex.Message); |
There was a problem hiding this comment.
Small detail (but don't worry about it): missing closing parenthesis at the end of the string.
This was referenced Mar 12, 2021
mburumaxwell
pushed a commit
to faluapp/falu-dotnet
that referenced
this pull request
Jun 12, 2021
Bumps [Moq](https://github.com/moq/moq4) from 4.16.0 to 4.16.1. #Changelog *Sourced from [Moq's changelog](https://github.com/moq/moq4/blob/main/CHANGELOG.md).* > ## 4.16.1 (2021-02-23) > > #### Added > > * `CallBase` can now be used with interface methods that have a default interface implementation. It will call [the most specific override](https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/proposals/csharp-8.0/default-interface-methods#the-most-specific-override-rule). (@stakx, [#1130](devlooped/moq#1130)) > > #### Changed > > * Improved error message formatting of `It.Is` lambda expressions that capture local variables. (@bfriesen, [#1140](devlooped/moq#1140)) > > #### Fixed > > * `AmbiguousMatchException` raised when interface has property indexer besides property in VB. (@mujdatdinc, [#1129](devlooped/moq#1129)) > * Interface default methods are ignored (@hahn-kev, [#972](devlooped/moq#972)) > * Callback validation too strict when setting up a task's `.Result` property (@stakx, [#1132](devlooped/moq#1132)) > * `setup.Returns(InvocationFunc)` wraps thrown exceptions in `TargetInvocationException` (@stakx, [#1141](devlooped/moq#1141)) #Commits - [`fc484fb`](devlooped/moq@fc484fb) Update version to 4.16.1 - [`0ddfdb8`](devlooped/moq@0ddfdb8) `Returns(InvocationFunc)` shouldn't throw `TargetInvocationException` - [`f36d3e8`](devlooped/moq@f36d3e8) Merge pull request [#1140](devlooped/moq#1140) from bfriesen/lambda_closure_support - [`e96804f`](devlooped/moq@e96804f) Update the changelog - [`5ae449c`](devlooped/moq@5ae449c) Exclude name of the closure class - [`8a2d2ed`](devlooped/moq@8a2d2ed) Add test for closure access - [`cf5af87`](devlooped/moq@cf5af87) Format lambda expression variables - [`5b10a8c`](devlooped/moq@5b10a8c) Add test for lamba matcher variables - [`653db31`](devlooped/moq@653db31) Some minor renames for consistency - [`fc73131`](devlooped/moq@fc73131) Add missing copyright notices - Additional commits viewable in [compare view](devlooped/moq@v4.16.0...v4.16.1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1138.