Make DefaultValue.Mock inherit property stubbing
#1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since that commit, inner mocks created by `Mock.Of<>()` no longer have their properties stubbed. `SetupAllProperties` is now only called for the root (outermost) mock. That's why nested properties can no longer be overridden simply by assigning to them.
The XML doc comment for `Mock<T>.SetupAllProperties()` states that: > If the mock's `DefaultValue` is set to `DefaultValue.Mock`, the > mocked default values will also get all properties setup recursively. But this does not actually happen! This commit changes the behavior of `DefaultValue.Mock` such that it does what it says on the tin. In theory, this could be a breaking change; let's see how many users have relied on behavior that contradicts the documentation. References: https://github.com/moq/moq4/blob/947c6a0aa1bbf265b5555ad0a84beb5bfc53b4e2/src/Moq/Mock.Generic.cs#L671-L674
stakx
force-pushed
the
inner-mocks-inherit-setupallproperties
branch
from
df0797b
to
ce2eb98
Compare
stakx
force-pushed
the
inner-mocks-inherit-setupallproperties
branch
from
ce2eb98
to
6abbc9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1071.
Note: While this introduces a small breaking change (at least in theory), it is one that fulfills a promise made by the pre-existing XML documentation for
SetupAllProperties:https://github.com/moq/moq4/blob/947c6a0aa1bbf265b5555ad0a84beb5bfc53b4e2/src/Moq/Mock.Generic.cs#L671-L674