Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSS file path in web UI. #353

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

t27duck
Copy link
Contributor

@t27duck t27duck commented Sep 6, 2021

Commit 07b9380 moved the styles to
a separate file and mount like the rest of the Sidekiq assets.

It looks like the CSS file does not have its path properly set up.

The CSS path has been adjusted so that it loads properly now.

Before:

Screen Shot 2021-09-06 at 11 57 44 AM

After:

Screen Shot 2021-09-06 at 11 58 14 AM

Fixes: #352

Commit 07b9380 moved the styles to
a separate file and mount like the rest of the Sidekiq assets.

It looks like the CSS file does not have its path properly set up.

The CSS path has been adjusted so that it loads properly now.
Copy link
Member

@marcelolx marcelolx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @t27duck!

@marcelolx marcelolx merged commit f4a58e7 into sidekiq-scheduler:master Sep 6, 2021
@ujh
Copy link

ujh commented Feb 7, 2022

I assume this layout is expected? I was going to open an issue on how it looks different from the old tabular layout, but now I am not sure if that isn't what's expected.

@marcelolx
Copy link
Member

marcelolx commented Feb 7, 2022

@ujh We did change the layout, please check #344 and the original PR that did start the change #267

@ujh
Copy link

ujh commented Feb 7, 2022

Thanks for the quick answer, @marcelolx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS file not loaded in scheduler UI
3 participants