Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more format examples to README #341

Merged

Conversation

vassilevsky
Copy link
Contributor

Hello 馃檭

I had a hard time understanding which formats for specifying periodic tasks are available. I even had to use a step debugger to get to the actual parsing code.

Here I submit my findings. Hope it will be useful to other users of this library.

Currently the README only mentions one-letter time durations. It looked like a step back from ActiveSupport-enabled durations we had in our Clockwork configuration, like every(15.minutes). That prompted my little research.

Maybe the description can be improved further. Let me know 馃檪

@coveralls
Copy link

coveralls commented Jun 4, 2021

Coverage Status

Coverage increased (+0.06%) to 97.917% when pulling d6fc012 on vassilevsky:feature/more-formats-in-readme into 1dcb266 on moove-it:master.

README.md Outdated Show resolved Hide resolved
@marcelolx marcelolx merged commit dc7f1f6 into sidekiq-scheduler:master Jun 7, 2021
@marcelolx
Copy link
Member

Thanks @vassilevsky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants