Missing Validate Functions on Base Segment Type

[mdross95]

Metro2 Version: 0.8.2

What were you trying to do?
Looking through base segment code in pkg/lib/base_segment.go.

What did you expect to see?
Expected to see Validate* functions that check provided values against a list of constants for all applicable base segment fields, similar to the existing ValidatePortfolioType().

What did you see?
Noticed absence of Validate* functions for quite a few applicable base segment fields in pkg/lib/base_segment.go. Examples I would have expected to see are ValidateAccountStatus(), ValidateAccountType(), ValidateSpecialComment(), and possibly more.

How can we reproduce the problem?
Constructing a base segment with, for example, AccountType of FF (an invalid CRRG value) and adding the segment via AddDataRecord allows the segment to be added, when I would expect a NewErrInvalidValueOfField error.

Mentioned this in the slack channel, happy to help with PR(s) to get some of these added if we decide it's appropriate!

[adamdecaf]

This would be great to add! Do you have a PR started we can help flush out?

[mdross95]

Great! I can have the PR up in the next day or two. Thanks!