Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aggregation failing if index does not exists #646

Merged
merged 1 commit into from Feb 6, 2022
Merged

Fix aggregation failing if index does not exists #646

merged 1 commit into from Feb 6, 2022

Conversation

dvvolynkin
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 25, 2020 •
edited

Codecov Report

Merging #646 (cac4d84) into develop (2826cac) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #646   +/-   ##
========================================
  Coverage    95.05%   95.06%           
========================================
  Files           19       19           
  Lines         3723     3726    +3     
========================================
+ Hits          3539     3542    +3     
  Misses         184      184
Impacted Files Coverage Δ
mongomock/aggregate.py 97.05% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2826cac...cac4d84. Read the comment docs.

pcorpet
pcorpet requested changes Jul 25, 2020
View reviewed changes
Copy link
Member

@pcorpet pcorpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

Please add a test in test__mongomock to ensure that there are no regression and that we have the same behavior than pymongo going forward.

@dvvolynkin
Copy link
Contributor Author

Done

@dvvolynkin dvvolynkin requested a review from pcorpet July 28, 2020 08:16
pcorpet
pcorpet requested changes Jul 30, 2020
View reviewed changes
mongomock/aggregate.py Show resolved Hide resolved
mongomock/aggregate.py Outdated Show resolved Hide resolved
@pcorpet pcorpet mentioned this pull request Feb 6, 2022
Closed
@pcorpet pcorpet merged commit 93da9a9 into mongomock:develop Feb 6, 2022
@pcorpet
Copy link
Member

pcorpet commented Feb 6, 2022

Thanks Daniil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcorpet pcorpet pcorpet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dvvolynkin @pcorpet