Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(NODE-6096): fix gcp kms tests #4084

Merged
merged 1 commit into from
Apr 17, 2024
Merged

test(NODE-6096): fix gcp kms tests #4084

merged 1 commit into from
Apr 17, 2024

Conversation

durran
Copy link
Member

@durran durran commented Apr 17, 2024 •
edited

Description

Fixes the GCP KMS test suite.

What is changing?

Updates the evergreen config to use the new setup and teardown scripts and pull env variables from the secrets manager.

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-6096

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran
Copy link
Member Author

durran commented Apr 17, 2024

Tasks passing: https://spruce.mongodb.com/version/662003a96def4900079531f2/tasks?page=0&sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC&variant=%5Erhel8-test-gcp-kms%24

@durran durran marked this pull request as ready for review April 17, 2024 17:21
@baileympearson baileympearson self-assigned this Apr 17, 2024
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Apr 17, 2024
@baileympearson baileympearson merged commit af18c53 into main Apr 17, 2024
18 of 26 checks passed
@baileympearson baileympearson deleted the NODE-6096 branch April 17, 2024 18:32
baileympearson pushed a commit that referenced this pull request Apr 18, 2024
@durran @baileympearson
test(NODE-6096): fix gcp kms tests (#4084)
a5a7b89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

Assignees

@baileympearson baileympearson

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
2 participants
@durran @baileympearson