Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(NODE-4826): update command monitoring tests #3488

Merged
merged 1 commit into from Dec 15, 2022
Merged

Conversation

durran
Copy link
Member

@durran durran commented Dec 15, 2022

Description

Updates command logging and monitoring tests to mongodb/specifications@735a667 to fix the failures on latest server due to the nonce command being removed.

What is changing?

  • Moves test/spec/command-monitoring to test/spec/command-logging-and-monitoring to match spec.
  • Moves test/integration/command-monitoring to test/integration/command-logging-and-monitoring to match directory structure.
  • Ignores the synced logging unified tests but syncs them to latest.
  • Syncs to the latest command logging and monitoring spec tests. (mongodb/specifications@735a667)
  • Fix the integration test that was checking nonce to use hello with speculativeAuthenticate
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-4826 and current failing evergreen builds on latest server.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran marked this pull request as ready for review December 15, 2022 20:37
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Dec 15, 2022
@baileympearson baileympearson merged commit dfcc3d9 into main Dec 15, 2022
@baileympearson baileympearson deleted the NODE-4826 branch December 15, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
2 participants