Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(NODE-4800): update build env scripts #3487

Merged
merged 2 commits into from Dec 16, 2022
Merged

test(NODE-4800): update build env scripts #3487

merged 2 commits into from Dec 16, 2022

Conversation

durran
Copy link
Member

@durran durran commented Dec 15, 2022

Description

Update to latest drivers evergreen tools scripts.

Test failures on latest related to: https://jira.mongodb.org/browse/DRIVERS-2490

What is changing?

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-4800

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran force-pushed the NODE-4800 branch 2 times, most recently from 3c0a073 to fe58666 Compare December 15, 2022 17:54
@durran durran marked this pull request as ready for review December 15, 2022 19:14
@baileympearson
Copy link
Contributor

There are a couple references to activate_venv in the test readme - can we update those references as well?

@durran
Copy link
Member Author

durran commented Dec 15, 2022

There are a couple references to activate_venv in the test readme - can we update those references as well?

Updated.

@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Dec 15, 2022
@baileympearson baileympearson merged commit 9f945c4 into main Dec 16, 2022
@baileympearson baileympearson deleted the NODE-4800 branch December 16, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
2 participants