Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(NODE-4790): retryable handshake errors spec sync #3472

Merged
merged 2 commits into from Nov 18, 2022
Merged

test(NODE-4790): retryable handshake errors spec sync #3472

merged 2 commits into from Nov 18, 2022

Conversation

dariakp
Copy link
Contributor

@dariakp dariakp commented Nov 18, 2022

Description

NODE-4790

What is changing?

  • Sync retryable read and write spec tests to latest
  • Skip tests for APIs our driver does not implement
  • Implement findOne operation in the unified test runner
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Spec compliance

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson marked this pull request as ready for review November 18, 2022 20:43
@baileympearson baileympearson merged commit fda7d25 into main Nov 18, 2022
@baileympearson baileympearson deleted the NODE-4790/improve-coverage-for-retryable-handshake-errors branch November 18, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dariakp @baileympearson